HDDS-5366. [Ozone-Streaming] Implement stream method to ContainerStateMachine. #2358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainzmc
changed the title
captainzmc
changed the title
szetszwo
reviewed
Jun 23, 2021
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@captainzmc , thanks a lot for working on this. Just have a minor comment.
BTW, let me update the HDDS-4454 branch with master. Please update your branch as well.
Comment on lines
508
to
527
Contributor
There was a problem hiding this comment.
We should make it async like below:
public CompletableFuture<DataStream> stream(RaftClientRequest request) {
return CompletableFuture.supplyAsync(() -> {
try {
ContainerCommandRequestProto requestProto =
getContainerCommandRequestProto(gid,
request.getMessage().getContent());
DispatcherContext context =
new DispatcherContext.Builder()
.setStage(DispatcherContext.WriteChunkStage.WRITE_DATA)
.setContainer2BCSIDMap(container2BCSIDMap)
.build();
ContainerCommandResponseProto response = runCommand(
requestProto, context);
String path = response.getMessage();
return new LocalStream(new StreamDataChannel(Paths.get(path))));
} catch (IOException e) {
throw new CompletionException("Failed to create data stream", e);
}
}, executor);
}
44f95ae to
51dd9c5
Compare
szetszwo
approved these changes
Jun 23, 2021
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Member
Author
|
Thanks @szetszwo for the review. |
captainzmc
added a commit
that referenced
this pull request
Jul 22, 2021
…eMachine. (#2358). Contributed by mingchao zhao
captainzmc
added a commit
to captainzmc/hadoop-ozone
that referenced
this pull request
Jul 26, 2021
…eMachine. (apache#2358). Contributed by mingchao zhao
captainzmc
added a commit
to captainzmc/hadoop-ozone
that referenced
this pull request
Jul 26, 2021
…eMachine. (apache#2358). Contributed by mingchao zhao
captainzmc
added a commit
to captainzmc/hadoop-ozone
that referenced
this pull request
Jul 27, 2021
…eMachine. (apache#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Jul 28, 2021
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Aug 26, 2021
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Sep 8, 2021
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Oct 1, 2021
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Oct 19, 2021
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Oct 28, 2021
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Nov 15, 2021
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Nov 30, 2021
…eMachine. (#2358). Contributed by mingchao zhao
captainzmc
added a commit
that referenced
this pull request
Dec 20, 2021
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Dec 30, 2021
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Jan 20, 2022
…eMachine. (#2358). Contributed by mingchao zhao
captainzmc
added a commit
that referenced
this pull request
Feb 9, 2022
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Feb 16, 2022
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Mar 15, 2022
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Mar 24, 2022
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
to szetszwo/ozone
that referenced
this pull request
May 6, 2022
…eMachine. (apache#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
May 13, 2022
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
May 24, 2022
…eMachine. (#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Jun 9, 2022
…eMachine. (#2358). Contributed by mingchao zhao
captainzmc
added a commit
to captainzmc/hadoop-ozone
that referenced
this pull request
Jul 4, 2022
…eMachine. (apache#2358). Contributed by mingchao zhao
szetszwo
pushed a commit
that referenced
this pull request
Nov 7, 2022
nishitpatira
pushed a commit
to nishitpatira/ozone
that referenced
this pull request
Dec 16, 2022
…eMachine. (apache#2358). Contributed by mingchao zhao (cherry picked from commit d4bf89a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use RATIS-Streaming to make ContainerStateMachine support writing streaming to the local.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5366
How was this patch tested?
CI test will be added after the client is finished